[asterisk-dev] [Code Review] 2478: Support multiple Require: and Supported: headers in the same request

[Olle E Johansson]

> On April 29, 2013, 2 p.m., Alec Davis wrote:
> > branches/1.8/channels/chan_sip.c, lines 22964-22966
> > <https://reviewboard.asterisk.org/r/2478/diff/1/?file=36549#file36549line22964>
> >
> >     aren't we double checking the 1st Require: here? Which in most cases is all we'll ever have.
> >

Right. Hmm. Needs to be improved.


- Olle E


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2478/#review8384
-----------------------------------------------------------


On April 29, 2013, 12:05 p.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2478/
> -----------------------------------------------------------
> 
> (Updated April 29, 2013, 12:05 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21721
>     https://issues.asterisk.org/jira/browse/ASTERISK-21721
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> We have servers sending multiple Supported: and Require: options in separate headers in the same message. This patch fixes that support so that we parse more than the first header found.
> 
> 
> Diffs
> -----
> 
>   branches/1.8/channels/chan_sip.c 386791 
> 
> Diff: https://reviewboard.asterisk.org/r/2478/diff/
> 
> 
> Testing
> -------
> 
> Tested with the server that caused the issue. Problem solved and we did reach interoperability!
> 
> 
> Thanks,
> 
> Olle E Johansson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130429/017c673c/attachment.htm>