[asterisk-dev] [Code Review] 2466: Pimp my SIP: Call forwarding & diversion headers

[Kevin Harwell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2466/
-----------------------------------------------------------

(Updated April 26, 2013, 6:48 p.m.)


Review request for Asterisk Developers, Joshua Colp and Mark Michelson.


Changes
-------

Addressed review findings.


Bugs: ASTERISK-21426
    https://issues.asterisk.org/jira/browse/ASTERISK-21426


Repository: Asterisk


Description
-------

Adds call forwarding support (Josh's patch) to the new SIP work being done in Asterisk.  This also includes the ability to add a diversion header to an outgoing response/request when appropriate.  The diversion header feature can be turned off by setting the send_diversion=false (defaults to true) on an endpoint within the configuration file.


Diffs (updated)
-----

  /team/group/pimp_my_sip/res/res_sip_diversion.c PRE-CREATION 
  /team/group/pimp_my_sip/res/res_sip/sip_configuration.c 386621 
  /team/group/pimp_my_sip/res/res_sip.c 386621 
  /team/group/pimp_my_sip/include/asterisk/res_sip.h 386621 
  /team/group/pimp_my_sip/channels/chan_gulp.c 386621 
  /team/group/pimp_my_sip/res/res_sip_session.c 386621 

Diff: https://reviewboard.asterisk.org/r/2466/diff/


Testing
-------

Wrote a few testsuite tests to make sure calls are being forwarded and the diversion header is added/propagated appropriately.


Thanks,

Kevin Harwell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130426/bb91fdbb/attachment.htm>