[asterisk-dev] [Code Review] 2471: Basic res_sip XML documentation

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2471/#review8354
-----------------------------------------------------------



team/group/pimp_my_sip/res/res_sip.c
<https://reviewboard.asterisk.org/r/2471/#comment16078>

    I'll elaborate further on this. pjsip will do transport resolution based on the SIP URI and the available transports, if one is not explicitly specified. IE: If the URI is IPv6 UDP it'll use the first IPv6 UDP transport.



team/group/pimp_my_sip/res/res_sip.c
<https://reviewboard.asterisk.org/r/2471/#comment16079>

    You can have multiple AORs.



team/group/pimp_my_sip/res/res_sip.c
<https://reviewboard.asterisk.org/r/2471/#comment16080>

    s/determine NATness/help traverse NAT/



team/group/pimp_my_sip/res/res_sip.c
<https://reviewboard.asterisk.org/r/2471/#comment16081>

    NAT hook is an internal implementation detail. It is not configurable and should not be documented or visible.


- Joshua Colp


On April 25, 2013, 2:07 a.m., Brad Latus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2471/
> -----------------------------------------------------------
> 
> (Updated April 25, 2013, 2:07 a.m.)
> 
> 
> Review request for Asterisk Developers and Matt Jordan.
> 
> 
> Bugs: ASTERISK-21668
>     https://issues.asterisk.org/jira/browse/ASTERISK-21668
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Start of XML documentation for res_sip, not complete but a start.
> 
> 
> Diffs
> -----
> 
>   team/group/pimp_my_sip/res/res_sip.c 386331 
>   team/group/pimp_my_sip/res/res_sip_acl.c 386331 
>   team/group/pimp_my_sip/res/res_sip_endpoint_identifier_ip.c 386331 
>   team/group/pimp_my_sip/res/res_sip_outbound_registration.c 386331 
> 
> Diff: https://reviewboard.asterisk.org/r/2471/diff/
> 
> 
> Testing
> -------
> 
> Ran xmllint - no errors.
> No warnings about missing XML during asterisk startup.
> 
> 
> Thanks,
> 
> Brad Latus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130425/2c23cf94/attachment-0001.htm>