[asterisk-dev] [Code Review] 2475: Fix SIP Notify / BLF Stop Working, after packet loss and 10 retries

[Alec Davis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2475/
-----------------------------------------------------------

(Updated April 25, 2013, 10:28 a.m.)


Review request for Asterisk Developers.


Changes
-------

Follow RFC6665, 4.2.2

Now remove subscription after the retries fail.

This now relies on the client to re-subscribe in a timely manner.

Ideally maxexpiry in sip.conf needs to be small, like 300, instead of the default of 3600 seconds.
This way, the BLF will not be wrong for too long. But that's a user setting.

Testing:
Make check that subscriptions are removed.

With Asterisk-11, also that when the device re-subscribes that the BLF is then correct, as immediate State Notification is now after each (re-)subscribe.


Bugs: ASTERISK-21677
    https://issues.asterisk.org/jira/browse/ASTERISK-21677


Repository: Asterisk


Description
-------

The notify sub system relies on a NOTIFY 200OK response to come back to clear the SIP_PAGE2_STATECHANGEQUEUE flag and p->pendinginvite
If the response never arrives, then any future NOTIFYs cannot EVER be sent, they just 'queue' up by replacing the previous queued notify.

The fix: assume after a period of time (2 seconds), if we haven't had a response, that the request/response got lost.


  


Diffs (updated)
-----

  branches/1.8/channels/chan_sip.c 386529 

Diff: https://reviewboard.asterisk.org/r/2475/diff/


Testing
-------

as per bug report  ASTERISK-21677


Thanks,

Alec Davis

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130425/f4515f1d/attachment-0001.htm>