[asterisk-dev] [Code Review] 2475: Fix SIP Notify / BLF Stop Working, after packet loss and 10 retries

[Alec Davis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2475/
-----------------------------------------------------------

Review request for Asterisk Developers.


Bugs: ASTERISK-21677
    https://issues.asterisk.org/jira/browse/ASTERISK-21677


Repository: Asterisk


Description
-------

The notify sub system relies on a NOTIFY 200OK response to come back to clear the SIP_PAGE2_STATECHANGEQUEUE flag and p->pendinginvite
If the response never arrives, then any future NOTIFYs cannot EVER be sent, they just 'queue' up by replacing the previous queued notify.

The fix: assume after a period of time (2 seconds), if we haven't had a response, that the request/response got lost.


  


Diffs
-----

  branches/11/channels/chan_sip.c 386529 
  branches/11/channels/sip/include/sip.h 386529 

Diff: https://reviewboard.asterisk.org/r/2475/diff/


Testing
-------

as per bug report  ASTERISK-21677


Thanks,

Alec Davis

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130425/173c598f/attachment-0001.htm>