[asterisk-dev] [Code Review] 2473: Minor readability improvements to chan_gulp

jrose reviewboard at asterisk.org
Thu Apr 25 01:08:55 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2473/#review8346
-----------------------------------------------------------

Ship it!


Nothing in here being fixed is technically against the style rules, but I'd be lying if I said I didn't feel like the code looked aesthetically better. It's a harmless patch, so commit when ready.

- jrose


On April 25, 2013, 2:38 a.m., Brad Latus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2473/
> -----------------------------------------------------------
> 
> (Updated April 25, 2013, 2:38 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21670
>     https://issues.asterisk.org/jira/browse/ASTERISK-21670
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Coding style tweaks, probably more my personal preference.
> Let the comments begin 
> 
> 
> Diffs
> -----
> 
>   /team/group/pimp_my_sip/channels/chan_gulp.c 386331 
> 
> Diff: https://reviewboard.asterisk.org/r/2473/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Brad Latus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130425/c589346c/attachment.htm>


More information about the asterisk-dev mailing list