[asterisk-dev] [Code Review] 2458: Bridging test: Test of the blind transfer feature to park channels

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2458/#review8330
-----------------------------------------------------------

Ship it!



/asterisk/trunk/tests/bridge/parkcall_blindxfer/Hangup.py
<https://reviewboard.asterisk.org/r/2458/#comment16017>

    This is the one thing I'm concerned with in this test. Often having to match explicitly on channel name in order to perform the correct action runs into problems - order changes (and now SIP/alice-00000008 is SIP/alice-00000006), which causes tests to fail.
    
    The problem is the AMI module callback option doesn't let you pass data to the callback, nor does it let you access the test object. This means you can't tell it from the YAML what iteration of the test you're on, nor can you access the test object to find the right channel names, which is unfortunate.
    
    I'd say go ahead with this for now - if we find that the test is unstable, we'll have to revisit the AMI pluggable module and make the callback option type a bit more flexible than it is today.


- Matt Jordan


On April 17, 2013, 10:21 p.m., jbigelow wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2458/
> -----------------------------------------------------------
> 
> (Updated April 17, 2013, 10:21 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This test uses BridgeTestCase to setup a bridge between two endpoints and utilizes the DTMF blind transfer feature to ensure the feature is detected. It also ensures that the transfered channels to the default, a static, and a dynamic parking lot are successful when the lots are not full. Lastly it fills a static and dynamic parking lot to ensure that further parking attempts fail. The AMI callback type is used to hang up the channels that were successfully and unsuccessfully parked.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/bridge/parkcall_blindxfer/Hangup.py PRE-CREATION 
>   /asterisk/trunk/tests/bridge/parkcall_blindxfer/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/bridge/parkcall_blindxfer/configs/ast1/features.conf PRE-CREATION 
>   /asterisk/trunk/tests/bridge/parkcall_blindxfer/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/bridge/tests.yaml 3718 
> 
> Diff: https://reviewboard.asterisk.org/r/2458/diff/
> 
> 
> Testing
> -------
> 
> * If more than one call is parked in the static or dynamic parking lot simultaneously the test fails as expected.
> * If the parking channel variables aren't found on the channel(s) then the test fails as expected.
> * If channels are not hung up the test fails as expected.
> 
> 
> Thanks,
> 
> jbigelow
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130419/a40f4e3a/attachment-0001.htm>