[asterisk-dev] [Code Review] 2428: Add channel event distribution to app_stasis

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2428/#review8324
-----------------------------------------------------------



trunk/include/asterisk/astobj2.h
<https://reviewboard.asterisk.org/r/2428/#comment16009>

    What's the compilation error?



trunk/include/asterisk/astobj2.h
<https://reviewboard.asterisk.org/r/2428/#comment16010>

    I suggest passing an enum ao2_container_opts to this function.



trunk/res/res_stasis.c
<https://reviewboard.asterisk.org/r/2428/#comment16013>

    I suggest wrapping this in a function to remove strings from a str_container.



trunk/res/res_stasis.c
<https://reviewboard.asterisk.org/r/2428/#comment16011>

    space after the first comma.



trunk/res/res_stasis.c
<https://reviewboard.asterisk.org/r/2428/#comment16012>

    This would feel a bit more clear if you return watching_apps instead of watching_apps_iter->c.


- Mark Michelson


On April 18, 2013, 2:59 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2428/
> -----------------------------------------------------------
> 
> (Updated April 18, 2013, 2:59 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21180
>     https://issues.asterisk.org/jira/browse/ASTERISK-21180
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Add publication of AMI-equivalent channel event messages to users of app_stasis using JSON blobs.
> 
> 
> Diffs
> -----
> 
>   trunk/include/asterisk/astobj2.h 385982 
>   trunk/include/asterisk/stasis_channels.h 385982 
>   trunk/main/astobj2.c 385982 
>   trunk/main/manager_channels.c 385982 
>   trunk/main/stasis_channels.c 385982 
>   trunk/res/res_stasis.c 385982 
>   trunk/res/res_stasis_websocket.c 385982 
> 
> Diff: https://reviewboard.asterisk.org/r/2428/diff/
> 
> 
> Testing
> -------
> 
> Tested with a hacked together app_stasis app which dumps incoming messages.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130419/03bacb58/attachment-0001.htm>