[asterisk-dev] [Code Review] 2455: Add support for DTMF via SIP INFO

[Jason Parker]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2455/
-----------------------------------------------------------

(Updated April 16, 2013, 8:26 p.m.)


Review request for Asterisk Developers.


Changes
-------

Address comments by Mark.


Bugs: ASTERISK-21261
    https://issues.asterisk.org/jira/browse/ASTERISK-21261


Repository: Asterisk


Description
-------

Sending is done inside of chan_gulp, if the dtmf= setting in res_sip.conf is set to info.  Receiving is done as a separate module, since that made the most sense, to me.


Diffs (updated)
-----

  /team/group/pimp_my_sip/channels/chan_gulp.c 385911 
  /team/group/pimp_my_sip/res/res_sip_dtmf_info.c PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/2455/diff/


Testing
-------

DTMF gets parsed properly.  Outgoing packet looks okay.


Thanks,

Jason Parker

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130416/5bfe582e/attachment.htm>