[asterisk-dev] [Code Review] 2424: Sorcery Realtime Wizard + Unit Test

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2424/#review8283
-----------------------------------------------------------

Ship it!


The only thing I think that is worth mentioning in CHANGES is a note that for future objects stored in realtime w/sorcery (which should be all of them, really), an 'id' field is required in the schema.

- Matt Jordan


On April 6, 2013, 3:58 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2424/
> -----------------------------------------------------------
> 
> (Updated April 6, 2013, 3:58 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change has three pieces:
> 
> 1. Conversion of realtime to use ast_variable instead of va_arg
> 2. A res_sorcery_realtime module for using all of the realtime config engines with sorcery
> 3. Unit tests for res_sorcery_realtime
> 
> There should be no functional impact as a result of the ast_variable conversion.
> 
> 
> Diffs
> -----
> 
>   /trunk/addons/res_config_mysql.c 383654 
>   /trunk/include/asterisk/config.h 383654 
>   /trunk/main/config.c 383654 
>   /trunk/main/sorcery.c 383654 
>   /trunk/res/res_config_curl.c 383654 
>   /trunk/res/res_config_ldap.c 383654 
>   /trunk/res/res_config_odbc.c 383654 
>   /trunk/res/res_config_pgsql.c 383654 
>   /trunk/res/res_config_sqlite3.c 383654 
>   /trunk/res/res_sorcery_realtime.c PRE-CREATION 
>   /trunk/tests/test_sorcery_realtime.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2424/diff/
> 
> 
> Testing
> -------
> 
> Ran against an actual realtime config engine, postgresql, to confirm that it works as expected. Ran it against unit tests as well to confirm that the wizard works as expected.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130415/aa6b7b24/attachment.htm>