[asterisk-dev] [Code Review] 2423: Pimp my SIP: Messaging

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2423/#review8244
-----------------------------------------------------------



/team/group/pimp_my_sip/channels/chan_gulp.c
<https://reviewboard.asterisk.org/r/2423/#comment15911>

    Use ast_free and no need for the NULL check since free accepts NULL pointers with no problem.



/team/group/pimp_my_sip/channels/chan_gulp.c
<https://reviewboard.asterisk.org/r/2423/#comment15910>

    The refcount on session should probably be bumped here and cleaned up on destruction.


- opticron


On April 9, 2013, 5:10 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2423/
> -----------------------------------------------------------
> 
> (Updated April 9, 2013, 5:10 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21076
>     https://issues.asterisk.org/jira/browse/ASTERISK-21076
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Adds messaging support to the new SIP work being done in Asterisk.  Both out of call and in-dialog MESSAGE requests are handled.
> 
> 
> Diffs
> -----
> 
>   /team/group/pimp_my_sip/channels/chan_gulp.c 385162 
>   /team/group/pimp_my_sip/res/res_sip.c 385162 
>   /team/group/pimp_my_sip/res/res_sip_messaging.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2423/diff/
> 
> 
> Testing
> -------
> 
> Wrote/modified several tests for the testsuite that include tests for both out of call and in-dialog MESSAGE requests, custom header propagation, MessageSend with specified from parameter, and the AMI MessageSend action.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130411/02ed4236/attachment.htm>