[asterisk-dev] [Code Review] 2443: Fix app_voicemail segfaulting and a few memory leaks

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2443/#review8242
-----------------------------------------------------------

Ship it!


All the fixes you've added look good by me. I second wdoekes's suggestion of having a helper function for determining valid configuration.

- Mark Michelson


On April 10, 2013, 9:55 p.m., Michael Young wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2443/
> -----------------------------------------------------------
> 
> (Updated April 10, 2013, 9:55 p.m.)
> 
> 
> Review request for Asterisk Developers and Jaco Kroon.
> 
> 
> Bugs: ASTERISK-21302
>     https://issues.asterisk.org/jira/browse/ASTERISK-21302
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch is the result of a combined effort by Jaco (jkroon) and myself.
> 
> The original report was that app_voicemail would crash when there was an error generated by having an invalid configuration file.
> 
> A patch was created to solve that problem by checking that the loaded configuration file was not invalid.
> 
> Jaco pointed out some areas where there were some memory leaks as well in app_voicemail.
> 
> 
> Diffs
> -----
> 
>   branches/11/apps/app_voicemail.c 384682 
> 
> Diff: https://reviewboard.asterisk.org/r/2443/diff/
> 
> 
> Testing
> -------
> 
> Tested on my dev machine after reproducing the crash.
> 
> I think that Jaco has also tested this patch out in his environment.
> 
> 
> Thanks,
> 
> Michael Young
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130411/b99d3be0/attachment-0001.htm>