[asterisk-dev] [Code Review] 2425: Add bridge CLI commands.

[rmudgett]

> On April 11, 2013, 7 p.m., opticron wrote:
> > /team/group/bridge_construction/main/bridging.c, lines 451-460
> > <https://reviewboard.asterisk.org/r/2425/diff/2/?file=35612#file35612line451>
> >
> >     This code can be pulled below the switch by putting a return in the default case to reduce indentation.  Other things can be done to reduce the indentation here as well.

Reducing indentation does not improve the code in this case.  This routine is coded to allow other checks to be added when needed.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2425/#review8232
-----------------------------------------------------------


On April 8, 2013, 9:45 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2425/
> -----------------------------------------------------------
> 
> (Updated April 8, 2013, 9:45 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21331
>     https://issues.asterisk.org/jira/browse/ASTERISK-21331
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> * Added bridge CLI commands:
> bridge destroy <bridge-id>
> bridge kick <bridge-id> <channel>
> bridge show all
> bridge show <bridge-id>
> bridge technology show
> bridge technology {suspend|unsuspend} <technology>
> 
> * Created global bridges container for manipulation by bridge CLI commands.
> 
> * Add ast_bridge_register() for ast_bridge_xxx_new() calls to register the bridge for access by the CLI commands.
> 
> 
> Diffs
> -----
> 
>   /team/group/bridge_construction/main/bridging.c 385038 
>   /team/group/bridge_construction/include/asterisk/bridging.h 385038 
>   /team/group/bridge_construction/main/features.c 385038 
> 
> Diff: https://reviewboard.asterisk.org/r/2425/diff/
> 
> 
> Testing
> -------
> 
> The new CLI commands work as expected.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130411/6ca15970/attachment-0001.htm>