[asterisk-dev] [Code Review] 2438: Add Stasis capability and AMI events around bridges

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2438/#review8233
-----------------------------------------------------------

Ship it!


I'm good with it, but it might be good if David ships it as well.


team/group/bridge_construction/include/asterisk/stasis_bridging.h
<https://reviewboard.asterisk.org/r/2438/#comment15895>

    I wouldn't document this as just a linked list. I'd reference the fact that it is an ao2_container of const char *, allocated with ast_str_container_alloc. That gives a developer sufficient information to know how to use and extract the contents.



team/group/bridge_construction/main/manager_bridging.c
<https://reviewboard.asterisk.org/r/2438/#comment15896>

    This could probably be smaller now.


- Matt Jordan


On April 11, 2013, 5:57 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2438/
> -----------------------------------------------------------
> 
> (Updated April 11, 2013, 5:57 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21057
>     https://issues.asterisk.org/jira/browse/ASTERISK-21057
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This adds the base of Stasis messages, topics, message types, caches, and snapshot generation points within the bridging code to facilitate access to bridge information without accessing bridges directly and also adds AMI events for bridge changes built on top of that Stasis layer.
> 
> The new function in strings.h (ast_str_container_alloc) allocates a new AO2 container for bare strings since this functionality seems to be required quite a bit more often lately.
> 
> 
> Diffs
> -----
> 
>   team/group/bridge_construction/main/strings.c 385233 
>   team/group/bridge_construction/main/stasis_bridging.c PRE-CREATION 
>   team/group/bridge_construction/main/manager_channels.c 385233 
>   team/group/bridge_construction/main/manager_bridging.c PRE-CREATION 
>   team/group/bridge_construction/main/bridging.c 385233 
>   team/group/bridge_construction/main/manager.c 385233 
>   team/group/bridge_construction/main/asterisk.c 385233 
>   team/group/bridge_construction/include/asterisk/strings.h 385233 
>   team/group/bridge_construction/include/asterisk/stasis_bridging.h PRE-CREATION 
>   team/group/bridge_construction/include/asterisk/manager.h 385233 
> 
> Diff: https://reviewboard.asterisk.org/r/2438/diff/
> 
> 
> Testing
> -------
> 
> Tested with Confbridge and BridgeWait to verify correct events are generated when calls enter and leave bridges.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130411/46c3aa05/attachment-0001.htm>