[asterisk-dev] [Code Review] 2439: Refactor AMI DTMF event generation; add DTMF events to stasis-http websocket

[David Lee]

> On April 10, 2013, 3:18 p.m., Paul Belanger wrote:
> > /trunk/main/manager_channels.c, line 241
> > <https://reviewboard.asterisk.org/r/2439/diff/1/?file=35676#file35676line241>
> >
> >     eep...
> >     
> >     what about AST_CLI_YESNO()? or breaking out that.  Seems like we should be keeping out translations in a central place.

I'm not going to include cli.h in manager code, but I'm willing to put an AST_YESNO in strings.h that both can use.

FWIW, there's almost 90 instances of '? "Yes" : "No"' sprinkled throughout the code, and almost 100 instances of AST_CLI_YESNO. So at least we do the right thing more than half the time, I guess.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2439/#review8221
-----------------------------------------------------------


On April 10, 2013, 1:48 p.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2439/
> -----------------------------------------------------------
> 
> (Updated April 10, 2013, 1:48 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21282 and ASTERISK-21359
>     https://issues.asterisk.org/jira/browse/ASTERISK-21282
>     https://issues.asterisk.org/jira/browse/ASTERISK-21359
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> DTMF events are now published on a channel's stasis_topic. AMI was
> refactored to use these events rather than producing the events directly
> in channel.c. Finally, the code was added to app_stasis to produce
> DTMF events on the WebSocket.
> 
> The AMI events are completely backward compatible, including sending
> events on transmitted DTMF, and sending DTMF start events.
> 
> The Stasis-HTTP events are somewhat simplified. Since DTMF start and
> DTMF send events are generally less useful, Stasis-HTTP will only send
> events on received DTMF end.
> 
> (closes issue ASTERISK-21282)
> (closes issue ASTERISK-21359)
> Review: https://reviewboard.asterisk.org/r/2439
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_stasis.c 385261 
>   /trunk/main/channel.c 385261 
>   /trunk/main/manager_channels.c 385261 
> 
> Diff: https://reviewboard.asterisk.org/r/2439/diff/
> 
> 
> Testing
> -------
> 
> Both AMI and Stasis DTMF events were generated for a few channels.
> 
> 
> Thanks,
> 
> David Lee
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130410/e7c4f98f/attachment-0001.htm>