[asterisk-dev] [Code Review] 2430: Moved core logic from app_stasis to res_stasis

[Paul Belanger]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2430/#review8207
-----------------------------------------------------------


trivial comment about formatting.


/trunk/main/stasis_channels.c
<https://reviewboard.asterisk.org/r/2430/#comment15837>

    Not sure if this formatting was intentional or not.
    
    Can you break it out for readability.  Same with the others below.


- Paul Belanger


On April 8, 2013, 4:40 p.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2430/
> -----------------------------------------------------------
> 
> (Updated April 8, 2013, 4:40 p.m.)
> 
> 
> Review request for Asterisk Developers, Matt Jordan and opticron.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> After some discussion on asterisk-dev, it was decided that the bulk of
> the logic in app_stasis actually belongs in a resource module instead
> of the application module.
> 
> This patch does that, leaves the app specific stuff in app_stasis, and
> fixes up everything else to be consistent with that change.
> 
>  * Renamed test_app_stasis to test_res_stasis
>  * Renamed app_stasis.h to stasis_app.h
>    * This is still stasis application support, even though it's no
>      longer in an app_ module. The name should never have been tied to
>      the type of module, anyways.
>  * Now that json isn't a resource module anymore, moved the
>    ast_channel_snapshot_to_json function to main/stasis_channels.c,
>    where it makes more sense.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/Makefile 384971 
>   /trunk/apps/app_stasis.c 384971 
>   /trunk/apps/app_stasis.exports.in 384971 
>   /trunk/apps/stasis_json.c 384971 
>   /trunk/include/asterisk/app_stasis.h 384971 
>   /trunk/include/asterisk/stasis_app.h PRE-CREATION 
>   /trunk/include/asterisk/stasis_channels.h 384971 
>   /trunk/main/stasis_channels.c 384971 
>   /trunk/res/res_stasis.c PRE-CREATION 
>   /trunk/res/res_stasis.exports.in PRE-CREATION 
>   /trunk/res/res_stasis_websocket.c 384971 
>   /trunk/tests/test_app_stasis.c 384971 
>   /trunk/tests/test_res_stasis.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2430/diff/
> 
> 
> Testing
> -------
> 
> Unit tests still pass.
> 
> 
> Thanks,
> 
> David Lee
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130408/7fb8587f/attachment.htm>