[asterisk-dev] reviewboard login required to view?

[Paul Belanger]

On 13-04-05 04:15 PM, David M. Lee wrote:
>
> On Apr 5, 2013, at 3:05 PM, Jonathan Rose wrote:
>
>> Paul Belanger <paul.belanger at polybeacon.com> wrote:
>>> Just noticed you need to have a login to review patches on
>>> reviewboard[1], do we really want that?
>>>
>>> [1] https://reviewboard.asterisk.org/dashboard/
>>
>> Hmmm, I don't think we do. This is probably just a
>> consequence of the upgrade to reviewboard done the
>> other day.
>
> Paul: Did you mean view or review?
>
> We've always required login to review (comment, create patch,
> etc.). Allowing anonymous reviews would be… well, let's just say
> there's a reason why we can't have nice things on the Internet.
>
> You *can* view patches without logging in. On the login screen,
> there's a link for 'All Review Requests' which show them all. Or you
> can click a link to an individual review.
>
> What may have changed is the default landing page. I don't remember
> what it used to be, but now the default landing page is the
> dashboard. But an anonymous user doesn't have a dashboard, so it takes
> them to the login page. If you login, it will take you to your
> dashboard.
>
> It is a bit wonky, so we may redirect
> https://reviewboard.asterisk.org/ to the All Review Requests
> page. That may have to wait until we get some other server management
> tasks out of the way, though.
>
The issue is https://reviewboard.asterisk.org/ requires a login, but if 
you go to https://reviewboard.asterisk.org/r/ is does not.


-- 
Paul Belanger | PolyBeacon, Inc.
Jabber: paul.belanger at polybeacon.com | IRC: pabelanger (Freenode)
Github: https://github.com/pabelanger | Twitter: 
https://twitter.com/pabelanger