[asterisk-dev] [Code Review] 2385: Default Global Settings Not Being Overridden - Asterisk 11

[Michael Young]

> On April 5, 2013, 4:17 a.m., wdoekes wrote:
> > Looks good to me. Thanks for fixing this eyesore.
> > 
> > I only wonder if this needs a mention somewhere. Perhaps a "BEWARE: please look over your sip.conf general settings. They may properly override the defaults now" in the commit message.
> > 
> > 
> > P.S. auto_* still trumps the other nat options, but only if they're specified. So a config like this will have auto_force_rport=yes comedia=yes
> >   nat=auto_force_rport
> >   nat=force_rport,comedia
> > But that could be considered a different bug.
> 
> Matt Jordan wrote:
>     I think a note in an UPGRADE file wouldn't hurt :-)

Sounds good to me on mentioning this fix somewhere.  The thought did go through my mind that some people may be surprised when their settings are now actually working.  UPGRADE sounds good to me.

If I understand the comment about auto_* setting trumping the other nat options, I think it is by design if I understand the comment in the sample config correctly:

"... If one of the "auto" settings
; is used in conjunction with its non-auto counterpart (nat=comedia,auto_comedia), then
; the non-auto option will be ignored."


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2385/#review8188
-----------------------------------------------------------


On April 4, 2013, 7:59 p.m., Michael Young wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2385/
> -----------------------------------------------------------
> 
> (Updated April 4, 2013, 7:59 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21225
>     https://issues.asterisk.org/jira/browse/ASTERISK-21225
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The initial report was that the "nat" setting in the [general] section was not having any effect in overriding the default setting.  Upon confirming this and checking into what was happening, it looks like other default settings would not be overridden as well.
> 
> This patch works similar to what occurs in build_peer().  We create a temporary ast_flags structure and using the mask, we override the default global options with whatever is set in the [general] section.
> 
> A different patch for 1.8 will be posted for review as well.
> 
> 
> Diffs
> -----
> 
>   /branches/11/channels/chan_sip.c 384804 
> 
> Diff: https://reviewboard.asterisk.org/r/2385/diff/
> 
> 
> Testing
> -------
> 
> Tested on my dev boxes.
> 
> Reporter also tested this patch on his machines and confirmed that everything is working properly.  He also noted that the "directmedia" settings are now being set properly as a result of this patch.
> 
> 
> Thanks,
> 
> Michael Young
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130405/291a08cf/attachment-0001.htm>