[asterisk-dev] [Code Review] 2424: Sorcery Realtime Wizard + Unit Test

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2424/
-----------------------------------------------------------

Review request for Asterisk Developers.


Repository: Asterisk


Description
-------

This change has three pieces:

1. Conversion of realtime to use ast_variable instead of va_arg
2. A res_sorcery_realtime module for using all of the realtime config engines with sorcery
3. Unit tests for res_sorcery_realtime

There should be no functional impact as a result of the ast_variable conversion.


Diffs
-----

  /trunk/addons/res_config_mysql.c 384670 
  /trunk/include/asterisk/config.h 384670 
  /trunk/main/config.c 384670 
  /trunk/res/res_config_curl.c 384670 
  /trunk/res/res_config_ldap.c 384670 
  /trunk/res/res_config_odbc.c 384670 
  /trunk/res/res_config_pgsql.c 384670 
  /trunk/res/res_config_sqlite3.c 384670 
  /trunk/res/res_sorcery_realtime.c PRE-CREATION 
  /trunk/tests/test_sorcery_realtime.c PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/2424/diff/


Testing
-------

Ran against an actual realtime config engine, postgresql, to confirm that it works as expected. Ran it against unit tests as well to confirm that the wizard works as expected.


Thanks,

Joshua Colp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130403/d6d65cbf/attachment.htm>