[asterisk-dev] [Code Review] 2385: Default Global Settings Not Being Overridden - Asterisk 11

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2385/#review8173
-----------------------------------------------------------



/branches/11/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/2385/#comment15766>

    ``dummy`` is not dummy any more. ``touchedflags`` perhaps?


- wdoekes


On March 13, 2013, 12:22 p.m., Michael Young wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2385/
> -----------------------------------------------------------
> 
> (Updated March 13, 2013, 12:22 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21225
>     https://issues.asterisk.org/jira/browse/ASTERISK-21225
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The initial report was that the "nat" setting in the [general] section was not having any effect in overriding the default setting.  Upon confirming this and checking into what was happening, it looks like other default settings would not be overridden as well.
> 
> This patch works similar to what occurs in build_peer().  We create a temporary ast_flags structure and using the mask, we override the default global options with whatever is set in the [general] section.
> 
> A different patch for 1.8 will be posted for review as well.
> 
> 
> Diffs
> -----
> 
>   /branches/11/channels/chan_sip.c 382825 
> 
> Diff: https://reviewboard.asterisk.org/r/2385/diff/
> 
> 
> Testing
> -------
> 
> Tested on my dev boxes.
> 
> Reporter also tested this patch on his machines and confirmed that everything is working properly.  He also noted that the "directmedia" settings are now being set properly as a result of this patch.
> 
> 
> Thanks,
> 
> Michael Young
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130403/54412bec/attachment.htm>