[asterisk-dev] [Code Review] 2408: Pimp Sip: Video support

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2408/#review8168
-----------------------------------------------------------



/team/group/pimp_my_sip/res/res_sip_session.c
<https://reviewboard.asterisk.org/r/2408/#comment15760>

    I think this should actually be expanded to do a check if a supplement exists capable of handling the given method. If so then return PJ_TRUE. That way in the future it will just work for everyone else and they won't have to touch this. Heck, may want to just make this the default even for non-PJSIP_OTHER_METHOD cases.


- Joshua Colp


On April 1, 2013, 4:05 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2408/
> -----------------------------------------------------------
> 
> (Updated April 1, 2013, 4:05 p.m.)
> 
> 
> Review request for Asterisk Developers and Joshua Colp.
> 
> 
> Bugs: ASTERISK-21077
>     https://issues.asterisk.org/jira/browse/ASTERISK-21077
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Adds video media handling support to the new SIP work being done in Asterisk.  Similar to audio added res_sip_sdp_video.c to handle sdp media negotiations for video.  Added capabilities support to make sure the correct codecs were being offered.  Also added the ability to handle the video source update control frame and initiate a fast video update request when needed.
> 
> 
> Diffs
> -----
> 
>   /team/group/pimp_my_sip/channels/chan_gulp.c 384465 
>   /team/group/pimp_my_sip/include/asterisk/res_sip_session.h 384465 
>   /team/group/pimp_my_sip/res/res_sip_sdp_audio.c 384465 
>   /team/group/pimp_my_sip/res/res_sip_sdp_rtp.c PRE-CREATION 
>   /team/group/pimp_my_sip/res/res_sip_session.c 384465 
> 
> Diff: https://reviewboard.asterisk.org/r/2408/diff/
> 
> 
> Testing
> -------
> 
> Using two softphones that support video was able to successfully connect, via asterisk, and view video.  Also monitored sip messages to make sure the appropriate media attributes were being propagated.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130402/7649fe2a/attachment-0001.htm>