[asterisk-dev] [Code Review] 2408: Pimp Sip: Video support

[Kevin Harwell]

> On March 28, 2013, 1:28 p.m., opticron wrote:
> > /team/group/pimp_my_sip/res/res_sip_sdp_media.c, lines 674-678
> > <https://reviewboard.asterisk.org/r/2408/diff/4/?file=35068#file35068line674>
> >
> >     This channel-specific information seems very out of place in a SDP handler and locks any channel driver using res_sip to a very specific file descriptor setup.

This was briefly discussed before (as its a carry over from a previous part of code) and it was decided to leave as is for now.


> On March 28, 2013, 1:28 p.m., opticron wrote:
> > /team/group/pimp_my_sip/res/res_sip_sdp_media.c, line 835
> > <https://reviewboard.asterisk.org/r/2408/diff/4/?file=35068#file35068line835>
> >
> >     This is a bit too generic as I don't think that this module will ever handle T38 or other things.  Maybe something about RTP since this will probably handle text in the future as well. These comments also apply to the name of the file itself.

Renamed file res_sip_sdp_rtp.c and updated the comments.  Hopefully this is sufficient enough to describe audio/video and eventually text.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2408/#review8145
-----------------------------------------------------------


On March 27, 2013, 6:40 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2408/
> -----------------------------------------------------------
> 
> (Updated March 27, 2013, 6:40 p.m.)
> 
> 
> Review request for Asterisk Developers and Joshua Colp.
> 
> 
> Bugs: ASTERISK-21077
>     https://issues.asterisk.org/jira/browse/ASTERISK-21077
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Adds video media handling support to the new SIP work being done in Asterisk.  Similar to audio added res_sip_sdp_video.c to handle sdp media negotiations for video.  Added capabilities support to make sure the correct codecs were being offered.  Also added the ability to handle the video source update control frame and initiate a fast video update request when needed.
> 
> 
> Diffs
> -----
> 
>   /team/group/pimp_my_sip/channels/chan_gulp.c 384117 
>   /team/group/pimp_my_sip/include/asterisk/res_sip_session.h 384117 
>   /team/group/pimp_my_sip/res/res_sip_authenticator_digest.c 384117 
>   /team/group/pimp_my_sip/res/res_sip_sdp_audio.c 384117 
>   /team/group/pimp_my_sip/res/res_sip_sdp_media.c PRE-CREATION 
>   /team/group/pimp_my_sip/res/res_sip_session.c 384117 
> 
> Diff: https://reviewboard.asterisk.org/r/2408/diff/
> 
> 
> Testing
> -------
> 
> Using two softphones that support video was able to successfully connect, via asterisk, and view video.  Also monitored sip messages to make sure the appropriate media attributes were being propagated.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130401/ff7f356b/attachment.htm>