[asterisk-dev] [Code Review] Change core show help output format.

[Leif Madsen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2133/#review7160
-----------------------------------------------------------

Ship it!


Haven't tested myself, but based on the output in your example, I like it!

- Leif


On Sept. 26, 2012, 3:08 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2133/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2012, 3:08 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> The CLI "core show help" output leaves something to be desired.
> 1) The command is truncated to a maximum of 30 characters.
> 2) The output columns are mirrored from the 31st column.
> 
> Current output format:
>                    logger mute Toggle logging output to a console
>                  logger reload Reopens the log files
>                  logger rotate Rotates and reopens the log files
> logger set level {DEBUG|NOTICE Enables/Disables a specific logging level for this console
>           logger show channels List configured log channels
> 
> 
> Proposed format:
> logger mute                    -- Toggle logging output to a console
> logger reload                  -- Reopens the log files
> logger rotate                  -- Rotates and reopens the log files
> logger set level {DEBUG|NOTICE|WARNING|ERROR|VERBOSE|DTMF} {on|off} -- Enables/Disables a specific logging level for this console
> logger show channels           -- List configured log channels
> 
> 
> Diffs
> -----
> 
>   /trunk/main/cli.c 373846 
> 
> Diff: https://reviewboard.asterisk.org/r/2133/diff
> 
> 
> Testing
> -------
> 
> Output looks a lot better.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120926/0edb1c86/attachment.htm>