[asterisk-dev] [Code Review] Sets -rpath linker option when appropriate

[Tilghman Lesher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2132/#review7158
-----------------------------------------------------------


Just by way of a note, when we first added the osx minimum version flag, it was meant to raise the floor, because at the time, if not specified, the Apple compiler would assume compatibility with 10.0.  At this point, since 10.8 is out, we could potentially raise that floor further, to 10.5 or 10.6, depending upon what minimum version of the Apple linker supports the -rpath option.

- Tilghman


On Sept. 26, 2012, 1:28 p.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2132/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2012, 1:28 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Sets -rpath linker option when appropriate.
> 
>  * For OS's other than OS X, add the -rpath linker option if libdir is
>    anything other than /lib or /usr/lib. This can be disabled by
>    passing --disable-rpath to ./configure.
>  * For OS X, we have macosx_version_min set to 10.4, which doesn't
>    support rpath. So instead, the patch adds the -dynamiclib and
>    -install_name flags for linking libasteriskssl.dylib, along with
>    cleaning up some of the other OS X specific linker flags.
> 
> 
> This addresses bug ASTERSIK-20407.
>     https://issues.asterisk.org/jira/browse/ASTERSIK-20407
> 
> 
> Diffs
> -----
> 
>   /branches/11/Makefile 373734 
>   /branches/11/configure UNKNOWN 
>   /branches/11/configure.ac 373734 
>   /branches/11/main/Makefile 373734 
>   /branches/11/makeopts.in 373734 
> 
> Diff: https://reviewboard.asterisk.org/r/2132/diff
> 
> 
> Testing
> -------
> 
> Built on OS X and Ubuntu Precise, --prefix=/opt/Asterisk, both with and without --disable-rpath.
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120926/51e1ace7/attachment.htm>