[asterisk-dev] [Code Review] app_queue: initialise "available agent' hint on restart, and other senarios

[Alec Davis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2129/
-----------------------------------------------------------

(Updated Sept. 25, 2012, 5:45 p.m.)


Review request for Asterisk Developers.


Changes
-------

added comment to init_queue() as follows:
        /* On restart assume no members are available.
         * The queue_avail hint is a boolean state to indicate whether a member is available or not.
         *
         * This seems counter intuitive, but is required to light a BLF
         * AST_DEVICE_INUSE indicates no members are available.
         * AST_DEVICE_NOT_INUSE indicates a member is available.
         */


Note: 'No members are available', includes all logged out.


Summary
-------

On queue initialisation set queue_avail devstate to INUSE.
 Previously was unavailable, which indicated an agent was available.

When removing members, if there are no other members available, set queue_avail to INUSE.
 Previously, if a member interface had become 'unavailable', they were never going to be removed, particularly when persistant queues is enabled.

When adding a member, check that they are available, if they are set queue_avail to NOT_INUSE.
 Previously on reloaded, members may have been 'unavailable'.

When pausing or unpausing a member, set appropriate queue availability. 


Diffs (updated)
-----

  trunk/apps/app_queue.c 373274 

Diff: https://reviewboard.asterisk.org/r/2129/diff


Testing
-------

Using CLI added non connected user to queues. Queue_avail state stayed at INUSE as expected.
 
Using CLI added and removed connected users to queues. Queue_avail state changed to NOT_INUSE then INUSE as expected.

Removed power from the only queue member and waited for the state to go unavailable, the queue_avail then went INUSE.


Thanks,

Alec

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120925/f65387bc/attachment-0001.htm>