[asterisk-dev] [Code Review] app_queue: initialise "available agent' hint on restart, and other senarios
Alec Davis
reviewboard at asterisk.org
Mon Sep 24 16:15:06 CDT 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2129/
-----------------------------------------------------------
(Updated Sept. 24, 2012, 4:15 p.m.)
Review request for Asterisk Developers.
Changes
-------
Added pause and unpause member, check if any members available.
Compiles and Tested
Summary (updated)
-------
On queue initialisation set queue_avail devstate to INUSE.
Previously was unavailable, which indicated an agent was available.
When removing members, if there are no other members available, set queue_avail to INUSE.
Previously, if a member interface had become 'unavailable', they were never going to be removed, particularly when persistant queues is enabled.
When adding a member, check that they are available, if they are set queue_avail to NOT_INUSE.
Previously on reloaded, members may have been 'unavailable'.
When pausing or unpausing a member, set appropriate queue availability.
Diffs (updated)
-----
trunk/apps/app_queue.c 373274
Diff: https://reviewboard.asterisk.org/r/2129/diff
Testing
-------
Using CLI added non connected user to queues. Queue_avail state stayed at INUSE as expected.
Using CLI added and removed connected users to queues. Queue_avail state changed to NOT_INUSE then INUSE as expected.
Removed power from the only queue member and waited for the state to go unavailable, the queue_avail then went INUSE.
Thanks,
Alec
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120924/0f40bf73/attachment.htm>
More information about the asterisk-dev
mailing list