[asterisk-dev] [Code Review]: Add the "stunport" configuration property to allow the standard STUN port to be overridden when generating ICE candidates.

[Brent Eagles]

> On Sept. 20, 2012, 11:56 a.m., Paul Belanger wrote:
> > /branches/11/res/res_rtp_asterisk.c, lines 3815-3822
> > <https://reviewboard.asterisk.org/r/2111/diff/4/?file=31329#file31329line3815>
> >
> >     minor nitpick, invert logic.  large blobs at top

Under other circumstances, I would simply agree with you. I took this approach because the if() test is consistent with another call to ast_parse_arg() earlier in the code. I did not want to have one be a test for failure and the second be a test for success. Thoughts?


- Brent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2111/#review7120
-----------------------------------------------------------


On Sept. 20, 2012, 11:56 a.m., Brent Eagles wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2111/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2012, 11:56 a.m.)
> 
> 
> Review request for Asterisk Developers and Joshua Colp.
> 
> 
> Summary
> -------
> 
> This patch adds support for a configuration property named "stunport" which is set in the "general" section of rtp.conf. The property allows a non-standard port to be configured for the stun server. A commented example entry was also added to rtp.conf.example.
> 
> 
> This addresses bug ASTERISK-20344.
>     https://issues.asterisk.org/jira/browse/ASTERISK-20344
> 
> 
> Diffs
> -----
> 
>   /branches/11/configs/rtp.conf.sample 373118 
>   /branches/11/res/res_rtp_asterisk.c 373118 
> 
> Diff: https://reviewboard.asterisk.org/r/2111/diff
> 
> 
> Testing
> -------
> 
> Test cases were ad-hoc and determined by visual inspection of generated candidates: 
> * property unset - default value, server reflexive entries visible
> * property set - valid value, server reflexive entries visible
> * property set - invalid value, server reflexive entries omitted
> 
> 
> Thanks,
> 
> Brent
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120921/cd5de896/attachment.htm>