[asterisk-dev] [Code Review]: app_queue: support a 'logged in and available' hint on queue

[Matt Jordan]

> On Sept. 20, 2012, 10:44 a.m., Mark Michelson wrote:
> > trunk/apps/app_queue.c, lines 1690-1693
> > <https://reviewboard.asterisk.org/r/2121/diff/3/?file=31315#file31315line1690>
> >
> >     This isn't sufficient to determine if a member is available.
> >     
> >     For instance, members who use analog devices will appear as AST_DEVICE_UNKNOWN when they are currently available.
> >     
> >     Also, if the queue has ringinuse set to "yes" then members who are AST_DEVICE_INUSE are considered available to the queue.
> >     
> >     There is a function available called num_available_members() that can be used to determine the number of members available for a queue. Use that instead.

You wouldn't be able to directly call num_available_members, as you just want to determine whether or not a member is actually available - not the number of available members.  You'd have to refactor out the portion of num_available_members that determines if a member is available to be callable by num_avilable_members and by this function.

That's a fairly minor correction that can be made to this patch.


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2121/#review7110
-----------------------------------------------------------


On Sept. 19, 2012, 4:45 p.m., Alec Davis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2121/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2012, 4:45 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Receptionist will love this.
> 
> The ability to see via a BLF that some members are logged in and free to take the calls. "I'll just put you through now", with less chance that the call goes to voicemail or what ever dialplan logic then followed.
> 
> 
> When all agents are logged out, the BLF goes INUSE.
> When agents are logged in, but are all busy, the BLF goes INUSE.
>    Like any BLF, if INUSE the call may go to Voicemail, at least the Operator can warn the caller.
> 
> When an agent is free to take a call the BLF goes NOT_IN_USE, IE. can put a call through.
>  
> 
> 
> Related to https://reviewboard.asterisk.org/r/1619/
> 
> I did think about combining the queue ringing hint from review 1619 but it's a different function, and only required by co-workers that may be able to help.
> 
> Many other divisions want to be able to drop a call into a queue, with the prior knowledge that it should be answered (NOTINUSE), or will possibly go to voicemail (INUSE).
> 
> 
> Diffs
> -----
> 
>   trunk/CHANGES 373162 
>   trunk/apps/app_queue.c 373162 
>   trunk/configs/extensions.conf.sample 373162 
> 
> Diff: https://reviewboard.asterisk.org/r/2121/diff
> 
> 
> Testing
> -------
> 
> In use on our headoffice production system.
> 
> Below is a hint for our itg_queue
> 
> exten => 8501,hint,Queue:itg_queue_avail
> 
> Note: '_avail' is added to the queuename
> 
> 
> Thanks,
> 
> Alec
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120920/dc893c54/attachment-0001.htm>