[asterisk-dev] [Code Review] Add the "stunport" configuration property to allow the standard STUN port to be overridden when generating ICE candidates.

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2111/#review7103
-----------------------------------------------------------



/branches/11/res/res_rtp_asterisk.c
<https://reviewboard.asterisk.org/r/2111/#comment13713>

    These are allocated from the pool, you can't free them.



/branches/11/res/res_rtp_asterisk.c
<https://reviewboard.asterisk.org/r/2111/#comment13714>

    You want to use ast_strdup here and not ast_strdupa, or dupe from the pool.



/branches/11/res/res_rtp_asterisk.c
<https://reviewboard.asterisk.org/r/2111/#comment13715>

    The turn variables are now a mish mash of pool allocated and ast_strdup allocated - should probably just pick one and stick with it.


- Joshua


On Sept. 14, 2012, 2:17 p.m., Brent Eagles wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2111/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2012, 2:17 p.m.)
> 
> 
> Review request for Asterisk Developers and Joshua Colp.
> 
> 
> Summary
> -------
> 
> This patch adds support for a configuration property named "stunport" which is set in the "general" section of rtp.conf. The property allows a non-standard port to be configured for the stun server. A commented example entry was also added to rtp.conf.example.
> 
> 
> This addresses bug ASTERISK-20344.
>     https://issues.asterisk.org/jira/browse/ASTERISK-20344
> 
> 
> Diffs
> -----
> 
>   /branches/11/configs/rtp.conf.sample 372768 
>   /branches/11/res/res_rtp_asterisk.c 372768 
> 
> Diff: https://reviewboard.asterisk.org/r/2111/diff
> 
> 
> Testing
> -------
> 
> Test cases were ad-hoc and determined by visual inspection of generated candidates: 
> * property unset - default value, server reflexive entries visible
> * property set - valid value, server reflexive entries visible
> * property set - invalid value, server reflexive entries omitted
> 
> 
> Thanks,
> 
> Brent
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120920/4e9e2660/attachment-0001.htm>