[asterisk-dev] [Code Review] SIP Session Timer: Call drops because misunderstanding of uac and uas refresher role

[Thomas Arimont]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2118/#review7101
-----------------------------------------------------------



/branches/1.8/configs/sip.conf.sample
<https://reviewboard.asterisk.org/r/2118/#comment13711>

    Is it worth here to say that this is also true if Asterisk is the callee?
    
    Due to RFC4028 Asterisk will always honor the caller's refresher SIP session timer preference (if there's any) for who will initially handle refreshs when Asterisk is the callee.
    
    And for completeness:
    During already initiated (timer) sessions, Asterisk will always honor the other endpoints's refresher preference if it's received in any subsequent SIP Re-Invite request - regardless of wether Asterisk is the caller or the callee, or wether Asterisk is currently the refresher or not.
    


- Thomas


On Sept. 19, 2012, 3:57 p.m., Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2118/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2012, 3:57 p.m.)
> 
> 
> Review request for Asterisk Developers and Thomas Arimont.
> 
> 
> Summary
> -------
> 
> From the issue:
> The SIP session timer mechanism contains a mandatory 'refresher' parameter (included in the Session-Expires header) which is used in the session timer offer/answer signaling within a SIP Invite dialog. It looks like asterisk is interpreting the uac resp. uas role only as the initial role of client and server (caller is uac, callee is uas). The standard rfc 4028 however assigns the client role to the ((RE)-Invite) requester, the server role to the ((RE)-Invite) responder.
> 
> This patch has Asterisk track the actual refresher as "us" or "them" as opposed to relying on just the configured "uas" or "uac" properties.
> 
> 
> This addresses bug AST-922.
>     https://issues.asterisk.org/jira/browse/AST-922
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/channels/chan_sip.c 373130 
>   /branches/1.8/channels/sip/include/sip.h 373130 
>   /branches/1.8/configs/sip.conf.sample 373130 
> 
> Diff: https://reviewboard.asterisk.org/r/2118/diff
> 
> 
> Testing
> -------
> 
> Calls with clients supporting and not supporting session timers with Asterisk having session-refresher=uas or uac.
> 
> 
> Thanks,
> 
> Terry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120920/55cbf5a6/attachment.htm>