[asterisk-dev] [Code Review] Improve direct media ACL support

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2122/#review7090
-----------------------------------------------------------

Ship it!


I can't find any fault with this. Looks good to go.

- jrose


On Sept. 19, 2012, 12:38 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2122/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2012, 12:38 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Direct media ACL support was improved to better reflect what people expected but introduced a requirement that in order to do direct media both sides must be the same channel technology. This was changed in 11 and trunk to allow remote bridging to occur despite differing channel technologies but direct media ACLs were no longer enforced. The changes in this patch remove this limitation and allow direct media to occur between differing channel types, with direct media ACLs applied if implemented and available.
> 
> 
> Diffs
> -----
> 
>   /branches/11/channels/chan_sip.c 373118 
>   /branches/11/include/asterisk/rtp_engine.h 373118 
>   /branches/11/main/rtp_engine.c 373118 
> 
> Diff: https://reviewboard.asterisk.org/r/2122/diff
> 
> 
> Testing
> -------
> 
> Tested without direct media ACLs to confirm that behavior is as previous.
> Tested with direct media ACL that forbid remote bridging, confirmed it was prevented.
> Tested with direct media ACL that allowed remote bridging, confirmed it occurred.
> 
> 
> Thanks,
> 
> Joshua
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120919/35b780e3/attachment.htm>