[asterisk-dev] [Code Review] Add -fnested-functions compile flag, if needed.

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2102/#review7076
-----------------------------------------------------------

Ship it!


Looks good to me.

I'll leave it to you if you want to fix the comment below.


/branches/11/configure.ac
<https://reviewboard.asterisk.org/r/2102/#comment13684>

    I'd prefer it if this said something about *where* we use nested functions too (in the RAII stuff apparently), since nested functions are not at all common.


- wdoekes


On Sept. 11, 2012, 11:30 a.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2102/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2012, 11:30 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> In order to use nested functions on some versions of GCC (e.g. GCC on OS X), the -fnested-functions flag must be passed to the compiler.
> 
> This patch:
> * Adds detection logic to ./configure
> * Adds AST_NESTED_FUNCTIONS to ./makeopts.in
> * Includes AST_NESTED_FUNCTIONS in _ASTCFLAGS
> 
> 
> This addresses bug ASTERISK-20399.
>     https://issues.asterisk.org/jira/browse/ASTERISK-20399
> 
> 
> Diffs
> -----
> 
>   /branches/11/Makefile 372844 
>   /branches/11/configure UNKNOWN 
>   /branches/11/configure.ac 372844 
>   /branches/11/include/asterisk/autoconfig.h.in 372844 
>   /branches/11/include/asterisk/utils.h 372844 
>   /branches/11/makeopts.in 372844 
> 
> Diff: https://reviewboard.asterisk.org/r/2102/diff
> 
> 
> Testing
> -------
> 
> Compiled on OS X and Ubuntu 12.04.
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120918/5b549ef3/attachment.htm>