[asterisk-dev] [Code Review] Named call pickup groups. Fixes, missing functionality, and improvements.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2112/
-----------------------------------------------------------

(Updated Sept. 14, 2012, 11:13 a.m.)


Review request for Asterisk Developers.


Changes
-------

Addressed Alec's review comments.


Summary
-------

* ASTERISK-20383
Missing named call pickup group features:

CHANNEL(callgroup) - Need CHANNEL(namedcallgroup)
CHANNEL(pickupgroup) - Need CHANNEL(namedpickupgroup)
Pickup() - Needs to also select from named pickup groups.

* ASTERISK-20384
Using the pickupexten, the pickup channel selection could fail even though there was a call it could have picked up. In a call pickup race when there are multiple calls to pickup and two extensions try to pickup a call, it is conceivable that the loser will not pick up any call even though it could have picked up the next oldest matching call.

Regression because of the named call pickup group feature.

* See ASTERISK-20386 for the improvements.

* Fixed some locking issues in CHANNEL().


This addresses bugs ASTERISK-20383, ASTERISK-20384 and ASTERISK-20386.
    https://issues.asterisk.org/jira/browse/ASTERISK-20383
    https://issues.asterisk.org/jira/browse/ASTERISK-20384
    https://issues.asterisk.org/jira/browse/ASTERISK-20386


Diffs (updated)
-----

  /trunk/apps/app_directed_pickup.c 373056 
  /trunk/funcs/func_channel.c 373056 
  /trunk/include/asterisk/channel.h 373056 
  /trunk/include/asterisk/features.h 373056 
  /trunk/main/channel.c 373056 
  /trunk/main/features.c 373056 

Diff: https://reviewboard.asterisk.org/r/2112/diff


Testing
-------

Tested call pickupexten, Pickup(), CHANNEL(namedcallgroup), and CHANNEL(namedpickupgroup) for named call group functionality.


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120914/8029127f/attachment.htm>