[asterisk-dev] [Code Review] Add the "stunport" configuration property to allow the standard STUN port to be overridden when generating ICE candidates.

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2111/#review7057
-----------------------------------------------------------


I don't think this change is necessary.

The stunaddr option uses PARSE_INADDR as the flag it passes to ast_parse_arg(). Since it does not specify PARSE_PORT_FORBID or PARSE_PORT_IGNORE, it means that a port can be specified on the end of the address like so:

stunaddr = stun.example.com:65432

Placing a separate stunport option seems like a step backward to me. In my opinion, representing the address and port as a single configuration option is better.

- Mark


On Sept. 13, 2012, 2:39 p.m., Brent Eagles wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2111/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2012, 2:39 p.m.)
> 
> 
> Review request for Asterisk Developers and Joshua Colp.
> 
> 
> Summary
> -------
> 
> This patch adds support for a configuration property named "stunport" which is set in the "general" section of rtp.conf. The property allows a non-standard port to be configured for the stun server. A commented example entry was also added to rtp.conf.example.
> 
> 
> This addresses bug AST-20344.
>     https://issues.asterisk.org/jira/browse/AST-20344
> 
> 
> Diffs
> -----
> 
>   /branches/11/configs/rtp.conf.sample 372768 
>   /branches/11/res/res_rtp_asterisk.c 372768 
> 
> Diff: https://reviewboard.asterisk.org/r/2111/diff
> 
> 
> Testing
> -------
> 
> Test cases were ad-hoc and determined by visual inspection of generated candidates: 
> * property unset - default value, server reflexive entries visible
> * property set - valid value, server reflexive entries visible
> * property set - invalid value, server reflexive entries omitted
> 
> 
> Thanks,
> 
> Brent
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120913/5625baf9/attachment.htm>