[asterisk-dev] [Code Review] Fix timeouts for ast_waitfordigit_full

[David Lee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2109/
-----------------------------------------------------------

(Updated Sept. 12, 2012, 5:31 p.m.)


Review request for Asterisk Developers and Mark Michelson.


Changes
-------

Handle negative timeout more consistently. Remove old comment that's no longer applicable


Summary
-------

ast_waitfordigit_full would simply pass its timeout to ast_waitfor_nandfds, expecting it to decrement the timeout by however many milliseconds were waited. This is a problem if it consistently waits less than 1ms, the timeout will never be decremented, and we wait... FOREVER!

This patch instead has ast_waitfordigit_full manage the timeout itself.


This addresses bug ASTERISK-20375.
    https://issues.asterisk.org/jira/browse/ASTERISK-20375


Diffs (updated)
-----

  /branches/1.8/main/channel.c 372975 

Diff: https://reviewboard.asterisk.org/r/2109/diff


Testing
-------

Mark confirmed that with the not-cleaned-up version of this patch, it fixed ASTERISK-20375. The cleanup consisted of changing variable names, adding comments, removing debug logging.


Thanks,

David

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120912/9c51e106/attachment.htm>