[asterisk-dev] [Code Review] res_xmpp: Fix a segfault occuring with bodyless messages during JABBER_RECEIVE function.

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2108/
-----------------------------------------------------------

(Updated Sept. 12, 2012, 1:19 p.m.)


Review request for Asterisk Developers and jcolp.


Summary
-------

Without this patch, Asterisk would receive an empty message (occurs when typing but not actually entering a message into clients like Trillian and Jabber) and this would reach ast_strdupa(message->message) causing a segfault. This patch works by preventing new messages from being finalized and entered into the message list if the body of that message is blank.


This addresses bug ASTERISK-20361.
    https://issues.asterisk.org/jira/browse/ASTERISK-20361


Diffs (updated)
-----

  /branches/11/res/res_xmpp.c 372832 

Diff: https://reviewboard.asterisk.org/r/2108/diff


Testing
-------

Noah confirmed that the patch averted his segfault problems while continuing to function normally.


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120912/1b96085a/attachment.htm>