[asterisk-dev] [Code Review]: Asterisk Call Pickup wiki page.

[rmudgett]

> On Sept. 10, 2012, 1:43 p.m., Mark Michelson wrote:
> > There are only a few problems I can find
> > 
> > * Section 2.3.1, the "pre-dial handler" link is red. I think the issue is that you need a hyphen between "pre" and "dial" instead of a space in the link.
> > * I'm not sure if the "Syntax" block in section 3.1 is going to be more harmful than helpful. First, people may get the idea that "groups" and "range" are potentially names of options that can be configured since their notation is not different from configuration examples. Second, I would not assume that the demographic reading the Asterisk wiki is necessarily familiar with BNF or similar grammars, so the notation may not mean much to them.
> > * Section 3.1 should state the bounds on numeric pickup groups.
> > * Incredibly nitpicky, but the second note in section 3.2 should be written in a more general form so that it cannot be misconstrued that your statement applies to the literal '4' instead of any number given to a call/pickup group.
> > 
> > Most of the data on the page is general call pickup information, so I agree with Alec's previous claim that placing it in the Asterisk 11 space seems a bit odd. The only part that specifically applies to Asterisk 11 is the new named groups feature. I think this could be moved some place else in the AST space, perhaps somewhere in "Configuration and Operation". Then, you'd need to specifically mention in the named groups section that the feature applies to Asterisk 11+ only.

* Fixed Pre-Dial link
* Adjusted the Syntax block
* The numeric range is already specified in the sentence before the Syntax block.
* Appended the second note as an example to the first note.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2100/#review7035
-----------------------------------------------------------


On Sept. 6, 2012, 3:05 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2100/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2012, 3:05 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> A new wiki page for review that describes call pickup is at
> https://wiki.asterisk.org/wiki/display/AST/Call+Pickup
> 
> 
> This addresses bug ASTERISK-20277.
>     https://issues.asterisk.org/jira/browse/ASTERISK-20277
> 
> 
> Diffs
> -----
> 
> 
> Diff: https://reviewboard.asterisk.org/r/2100/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120911/2c2f6a96/attachment-0001.htm>