[asterisk-dev] [Code Review] Add -fnested-functions compile flag, if needed.

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2102/#review7043
-----------------------------------------------------------



/branches/11/configure.ac
<https://reviewboard.asterisk.org/r/2102/#comment13646>

    I'm not sure how relevant this is, but I know that in all places in Asterisk where we use nested functions, we place the "auto" keyword in front of the function. This helps to clear up some compiler errors/warnings on certain versions of GCC.
    
    I'm not sure if your test is purposely leaving off "auto" or if you need to add it here in order to head off false positives.


- Mark


On Sept. 10, 2012, 10:22 a.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2102/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2012, 10:22 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> In order to use nested functions on some versions of GCC (e.g. GCC on OS X), the -fnested-functions flag must be passed to the compiler.
> 
> This patch:
> * Adds detection logic to ./configure
> * Adds AST_NESTED_FUNCTIONS to ./makeopts.in
> * Includes AST_NESTED_FUNCTIONS in _ASTCFLAGS
> 
> 
> This addresses bug ASTERISK-20399.
>     https://issues.asterisk.org/jira/browse/ASTERISK-20399
> 
> 
> Diffs
> -----
> 
>   /branches/11/Makefile 372735 
>   /branches/11/configure UNKNOWN 
>   /branches/11/configure.ac 372735 
>   /branches/11/include/asterisk/autoconfig.h.in 372735 
>   /branches/11/makeopts.in 372735 
> 
> Diff: https://reviewboard.asterisk.org/r/2102/diff
> 
> 
> Testing
> -------
> 
> Compiled on OS X and Ubuntu 12.04.
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120911/a017a9eb/attachment.htm>