[asterisk-dev] [Code Review] Add support for ${} parsing in sip_notify.conf

[gareth]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2074/
-----------------------------------------------------------

(Updated Sept. 10, 2012, 11:12 p.m.)


Review request for Asterisk Developers.


Changes
-------

Updated patch to latest version and added support for setting variables configured with setvar=.

A patch for functions that call autoservice was submitted in ASTERISK-20283.


Summary (updated)
-------

This is the second part split out from the much larger patch at https://reviewboard.asterisk.org/r/1976/ - this part contains the code required to get the phone to restart or reset from a SIP NOTIFY requuest:

- Add ${} parsing for sip_notify.conf, PEERNAME variable contains the name of the peer being sent the notification.

- Allows the user to specify their own Subscription-State header as the Cisco phones require 'active' instead of 'terminated'.

There are probably other uses for this especially when paired with using Content => ${SHELL(/path/to/script "${PEERNAME}")} etc. 

Note: Using SHELL() and CURL() emit errors here because they try to start autoservice on the channel. Not sure what the best fix for that is, maybe checking for dummy channels ast_autoservice_{start|stop} and treating it as a no-op.

Addendum: I submitted a patch to fix the above problem: ASTERISK-20283.


Diffs (updated)
-----

  /trunk/CHANGES 372831 
  /trunk/UPGRADE-11.txt 372831 
  /trunk/channels/chan_sip.c 372831 
  /trunk/configs/sip_notify.conf.sample 372831 

Diff: https://reviewboard.asterisk.org/r/2074/diff


Testing
-------

Sent a few notifications to a peer containing ${} contructs.


Thanks,

gareth

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120911/5a036740/attachment-0001.htm>