[asterisk-dev] [Code Review] chan_sip: Manager action SIPQualifyPeer response changes

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2098/#review7024
-----------------------------------------------------------


Make sure the new event is mentioned in the CHANGES file.

Although chan_sip hasn't had its AMI events documented yet, you may as well add XML documentation to the new qualify finished event (the ack/error responses aren't part of the AMI Event documentation yet).  Make sure you add a reference back to the AMI command that caused the event to occur in the first place.

- Matt


On Sept. 6, 2012, 11:47 a.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2098/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2012, 11:47 a.m.)
> 
> 
> Review request for Asterisk Developers, Olle E Johansson and Matt Jordan.
> 
> 
> Summary
> -------
> 
> Last week a patch was made to add some feedback for SIPQualifyPeer upon completion. Olle brought up the point that sip_poke_peer may take a considerable amount of time to resolve, so this patch adds an acknowledgement of 'will qualify' right before performing the sip_poke_peer. The response upon completion of the poke has been removed and instead an event is in place (SIPQualifyPeerComplete) to address that.
> 
> Matt mentioned in the same email thread that the event itself may not be necessary. Further discussion didn't take place, so that needs to be answered. If we decide the event is appropriate, it will need to be documented.
> 
> 
> This addresses bug AST-969.
>     https://issues.asterisk.org/jira/browse/AST-969
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 371997 
> 
> Diff: https://reviewboard.asterisk.org/r/2098/diff
> 
> 
> Testing
> -------
> 
> The simple stuff, ran qualify peer event and made sure the response and event went through as expected.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120907/371a47fa/attachment.htm>