[asterisk-dev] [Code Review] LDAP Realtime Peers Cannot Register

[Darren Sessions]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2095/
-----------------------------------------------------------

(Updated Sept. 4, 2012, 3:38 p.m.)


Review request for Asterisk Developers.


Summary
-------

"Prior to 1.8, it was not necessary for an explicit "type" to be set for an asterisk LDAP realtime peer. Now the routine find_peer actually checks the type field during registration and fails to find the peer if it is not set.

The attached patch makes a realtime peer be "type=peer" if it is still type 0 upon return from routine build_peer."


This addresses bug ASTERISK-17222.
    https://issues.asterisk.org/jira/browse/ASTERISK-17222


Diffs (updated)
-----

  /trunk/channels/chan_sip.c 372134 
  /trunk/configs/res_ldap.conf.sample 372134 

Diff: https://reviewboard.asterisk.org/r/2095/diff


Testing
-------

Compiled a clean copy of trunk to replicate the issue and then applied the patch and observed the correct (and intended) behavior.


Thanks,

Darren

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120904/38c035d3/attachment.htm>