[asterisk-dev] [Code Review] dsp.c: dtmf_detect, Fix multiple issues when no-interdigit delay is present.

[Alec Davis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2085/
-----------------------------------------------------------

(Updated Sept. 1, 2012, 2:59 a.m.)


Review request for Asterisk Developers.


Changes
-------

Revert to original -r349249 method with some changes, remove unnecessary;
  1. reseting of hits=0, when no signal, only need to set it once.
  2. incrementing of hits, when the hit is the same as the current hit.
  3. setting of lasthit, when it's the same as before.

It does limit the minimum hits_to_begin to 2


Summary
-------

Document DTMF events for different sequences.

* Fix extra hit required when new DIGIT is sent without any interdigit delay.
* Fix when DTMF_HITS_TO_BEGIN = 2, and no interdigit gap, that BEGIN is posted. 
* Fix situation where a flakey detect, would clear the current_hit (indicating an END), which may not have been the case.


Diffs (updated)
-----

  trunk/main/dsp.c 371689 

Diff: https://reviewboard.asterisk.org/r/2085/diff


Testing
-------

On production box for 24 hours. 888 digit's now received.

The change here doesn't affect normal tone on/tone off, it changes the case when no interdigit pause is received between 2 digits, now the 2 digit has the same detect time as if there had been an interdigit pause before hand.


Thanks,

Alec

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120901/136e55d0/attachment.htm>