[asterisk-dev] [Code Review]: Post trunk-resurrection fixes to libss7.

[KNK]

> On Oct. 17, 2012, 12:49 p.m., rmudgett wrote:
> > /trunk/isup.c, line 2768
> > <https://reviewboard.asterisk.org/r/2150/diff/1/?file=31757#file31757line2768>
> >
> >     isup_init_call() should now be made static and removed from the libss7 API.

Done.


> On Oct. 17, 2012, 12:49 p.m., rmudgett wrote:
> > /trunk/isup.c, line 2769
> > <https://reviewboard.asterisk.org/r/2150/diff/1/?file=31757#file31757line2769>
> >
> >     This needs to be done by a new API call.  A new call structure can be created for other reasons than to send an IAM: GRS, RSC, BLO, UBL, etc.
> >     
> >     isup_iam() should clear the ISUP_PENDING_IAM flag because IAM is no longer pending.

I am hesitant about this change. There is no need to add a new API call for a single bit and 'ISUP_PENDING_IAM' means (for me) 'consider we have sent IAM, but just not yet', so it is just in place with got/sent message.
There is no real need to clear it as it is always checked after ISUP_SENT_IAM, but it should be on REL ... done in both places.


- KNK


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2150/#review7291
-----------------------------------------------------------


On Oct. 5, 2012, 9:47 a.m., KNK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2150/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2012, 9:47 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Dual seizure - check for IAM pending in addition to IAM sent
> ISUP_RSC - we should still respond to RSC
> 
> 
> This addresses bug SS7-27.
>     https://issues.asterisk.org/jira/browse/SS7-27
> 
> 
> Diffs
> -----
> 
>   /trunk/isup.c 320 
>   /trunk/libss7.h 320 
>   /trunk/ss7linktest.c 320 
> 
> Diff: https://reviewboard.asterisk.org/r/2150/diff
> 
> 
> Testing
> -------
> 
> compiles
> 
> 
> Thanks,
> 
> KNK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121030/9d61ffb7/attachment.htm>