[asterisk-dev] [Code Review] Get mixmonitor_audiohook_inherit test working again

jrose reviewboard at asterisk.org
Mon Oct 29 12:06:57 CDT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2139/
-----------------------------------------------------------

(Updated Oct. 29, 2012, 12:06 p.m.)


Review request for Asterisk Developers and Matt Jordan.


Changes
-------

address mmichelson's review


Summary
-------

This is part of an effort to get tests working that are currently being skipped due to failures. I went ahead and changed this test to use the TestCase class since the old way of doing things was driving me nuts with various problems.


Diffs (updated)
-----

  /asterisk/trunk/tests/apps/mixmonitor_audiohook_inherit/configs/ast1/extensions.conf 3496 
  /asterisk/trunk/tests/apps/mixmonitor_audiohook_inherit/configs/ast1/features.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/mixmonitor_audiohook_inherit/configs/ast1/manager.conf 3496 
  /asterisk/trunk/tests/apps/mixmonitor_audiohook_inherit/run-test 3496 
  /asterisk/trunk/tests/apps/mixmonitor_audiohook_inherit/test-config.yaml 3496 

Diff: https://reviewboard.asterisk.org/r/2139/diff


Testing
-------

To test the test I ran the test with normal conditions, with an improper filename specified for the mixmonitor command, and also with turning off audiohook_inherit. All deviations caused failure as expected.


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121029/4431013b/attachment.htm>


More information about the asterisk-dev mailing list