[asterisk-dev] [Code Review] Get mixmonitor_audiohook_inherit test working again

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2139/#review7330
-----------------------------------------------------------


I think you can get rid of the file size check from this test entirely. In my view, the goal of this test is to ensure that the MixMonitor continues recording after the transfer occurs. Your test event coupled with your user event ensure that is the case. This test shouldn't care about the actual recording since there is already a MixMonitor test that ensures that MixMonitor records audio to a file.


/asterisk/trunk/tests/apps/mixmonitor_audiohook_inherit/run-test
<https://reviewboard.asterisk.org/r/2139/#comment14118>

    All of the 1s throughout the test are a bit weird since there aren't any other tests run.



/asterisk/trunk/tests/apps/mixmonitor_audiohook_inherit/run-test
<https://reviewboard.asterisk.org/r/2139/#comment14117>

    PEP8: Remove the spaces around the assignments in the parameter list.


- Mark


On Oct. 23, 2012, 2:54 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2139/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2012, 2:54 p.m.)
> 
> 
> Review request for Asterisk Developers and Matt Jordan.
> 
> 
> Summary
> -------
> 
> This is part of an effort to get tests working that are currently being skipped due to failures. I went ahead and changed this test to use the TestCase class since the old way of doing things was driving me nuts with various problems.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/apps/mixmonitor_audiohook_inherit/configs/ast1/extensions.conf 3496 
>   /asterisk/trunk/tests/apps/mixmonitor_audiohook_inherit/configs/ast1/features.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/mixmonitor_audiohook_inherit/configs/ast1/manager.conf 3496 
>   /asterisk/trunk/tests/apps/mixmonitor_audiohook_inherit/run-test 3496 
>   /asterisk/trunk/tests/apps/mixmonitor_audiohook_inherit/test-config.yaml 3496 
> 
> Diff: https://reviewboard.asterisk.org/r/2139/diff
> 
> 
> Testing
> -------
> 
> To test the test I ran the test with normal conditions, with an improper filename specified for the mixmonitor command, and also with turning off audiohook_inherit. All deviations caused failure as expected.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121029/1d499962/attachment-0001.htm>