[asterisk-dev] [Code Review] Complete DTMF digit when bridge is broken.

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2169/#review7329
-----------------------------------------------------------



/branches/1.8/include/asterisk/channel.h
<https://reviewboard.asterisk.org/r/2169/#comment14116>

    1) Clarify the wording of sending_dtmf_digit so that it's clear that it's Asterisk sending the digit out and not the far end sending the digit to Asterisk. I initially read it as the digit being sent by the far end to Asterisk since the word "channel" is sometimes used to describe the entity being communicated with by Asterisk.
    
    2) Clearly indicate that sending_dtmf_tv is invalid if sending_dtmf_digit is 0.


- Mark


On Oct. 25, 2012, 4:11 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2169/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2012, 4:11 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Using the AMI redirect action or ChannelRedirect application on a bridged call to transfer a channel can result in a stuck DTMF digit on the channel sending the digit.
> Initial scenario that resulted in a stuck DTMF digit on a channel:
> 1) A is bridged with B (It doesn't matter who called whom)
> 2) B is sending a DTMF digit to A.
> 3) An AMI redirect action or the ChannelRedirect application redirects A to another channel or dialplan extension.
> 4) A will be stuck sending DTMF
> 
> Another scenario that could result in a stuck DTMF digit on a channel is the following:
> 1) A calls B
> 2) B is sending a DTMF digit to A
> 3) An AMI hangup action is done to B.
> 4) A will be stuck sending DTMF if it is setup to execute dialplan after the bridge exits.  (Dial g option)
> 
> 
> This addresses bug ASTERISK-20492.
>     https://issues.asterisk.org/jira/browse/ASTERISK-20492
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/include/asterisk/channel.h 375354 
>   /branches/1.8/include/asterisk/features.h 375354 
>   /branches/1.8/main/channel.c 375354 
>   /branches/1.8/main/features.c 375354 
> 
> Diff: https://reviewboard.asterisk.org/r/2169/diff
> 
> 
> Testing
> -------
> 
> Both scenarios get the simulated DTMF end digit.
> For DAHDI channels, the initial scenario would result in A hearing ringback even though C answered and C could not hear anything from A.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121029/b2d396f5/attachment.htm>