[asterisk-dev] [Code Review] MixMonitor Leaves Empty Audio Files Behind

[elguero]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2068/
-----------------------------------------------------------

(Updated Oct. 23, 2012, 7:10 p.m.)


Review request for Asterisk Developers.


Changes
-------

- Formatting fixes
- While trying to optimize a line of code, found some logic that needed to be corrected


Summary
-------

When the MixMonitor application is started, it creates an empty audio file (just the header is present) for writing an audio stream.

In the event that MixMonitor is started before dialing (in the case on the issue, record only a bridged channel) but the bridge never is setup due to the other side not answering or for whatever reason the bridge did not succeed in being created, MixMonitor does not clean up the empty audio file.  This has the effect of leaving empty audio files behind.

The proposed patch determines if a file had audio written to it or not.  If no audio was written to the file and we are not appending audio to a pre-existing audio file, the file will be removed.


This addresses bug ASTERISK-20156.
    https://issues.asterisk.org/jira/browse/ASTERISK-20156


Diffs (updated)
-----

  /branches/10/UPGRADE.txt 375324 
  /branches/10/apps/app_mixmonitor.c 375324 

Diff: https://reviewboard.asterisk.org/r/2068/diff


Testing
-------

Reproducing this issue is pretty straight forward.  I tested this patch on one of my local dev machines.  I have yet to get a response on the issue as to whether it is working for the original reporter.

Update: I have done testing on two different boxes.  I have tested under Asterisk 10 and under trunk.


Thanks,

elguero

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121024/390d082a/attachment.htm>