[asterisk-dev] [Code Review] Make dialplan variable evaluation case-sensitive

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2160/#review7300
-----------------------------------------------------------

Ship it!


No comments on the wiki page.

Do put something into the UPGRADE.txt file about this though.


/trunk/channels/chan_mgcp.c
<https://reviewboard.asterisk.org/r/2160/#comment14095>

    Huh, I wonder why this was done in the first place ... oh well, probably legacy and maybe pbx_builtin_getvar_helper didn't exist. Oh well!


- Joshua


On Oct. 12, 2012, 1:04 p.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2160/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2012, 1:04 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> For more information on this, see this companion wiki page: https://wiki.asterisk.org/wiki/display/AST/Case+Sensitivity
> 
> In this review, please comment both on the code change and the wiki page. I don't suspect there will be much to comment on in the code...
> 
> 
> This addresses bug ASTERISK-20163.
>     https://issues.asterisk.org/jira/browse/ASTERISK-20163
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_osplookup.c 374915 
>   /trunk/channels/chan_mgcp.c 374915 
>   /trunk/channels/chan_sip.c 374924 
>   /trunk/channels/chan_skinny.c 374915 
>   /trunk/funcs/func_strings.c 374915 
>   /trunk/main/pbx.c 374915 
> 
> Diff: https://reviewboard.asterisk.org/r/2160/diff
> 
> 
> Testing
> -------
> 
> I ran some calls where I set variables and ensured that they only evaluated to non-empty strings when the same case was used as when originally setting the variable.
> 
> 
> Thanks,
> 
> Mark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121018/ed3ad3fa/attachment-0001.htm>