[asterisk-dev] [Code Review] app_alarmreceiver new features and fixes

[Pedro Kiefer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2088/#review7288
-----------------------------------------------------------


Looks good! Just need to test it.


/trunk/apps/app_alarmreceiver.c
<https://reviewboard.asterisk.org/r/2088/#comment14071>

    write_metadata return 0 when successful. With statement we are not writing the events data to the file, and return failure to the caller of log_events.


- Pedro


On Oct. 17, 2012, 8:39 a.m., KNK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2088/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2012, 8:39 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Adds new formats to app_alarmreceiver, ALAW calls support and protection from broken panels and malicious callers
> 
> 
> This addresses bug ASTERISK-20289.
>     https://issues.asterisk.org/jira/browse/ASTERISK-20289
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_alarmreceiver.c 375136 
>   /trunk/configs/alarmreceiver.conf.sample 375136 
> 
> Diff: https://reviewboard.asterisk.org/r/2088/diff
> 
> 
> Testing
> -------
> 
> All new functionality was tested
> 
> 
> Thanks,
> 
> KNK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121017/22d985cb/attachment.htm>