[asterisk-dev] [Code Review] Fix double DTMF digits when 'dtmfmode=inband' and client sends both 'inband' and 'SIP INFO' packets

[Alec Davis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2165/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

Asterisk 1.8.16.0

file:/var/log/asterisk/dtmf when only '2' was hit once
[2012-10-17 19:46:17.879406] DTMF[17084] channel.c: DTMF begin '2' received on SIP/822-00000000
[2012-10-17 19:46:17.879467] DTMF[17084] channel.c: DTMF begin ignored '2' on SIP/822-00000000
[2012-10-17 19:46:17.950953] DTMF[17084] channel.c: DTMF end '2' received on SIP/822-00000000, duration 800 ms
[2012-10-17 19:46:17.951004] DTMF[17084] channel.c: DTMF end passthrough '2' on SIP/822-00000000
[2012-10-17 19:46:18.019135] DTMF[17084] channel.c: DTMF end '2' received on SIP/822-00000000, duration 51 ms
[2012-10-17 19:46:18.019228] DTMF[17084] channel.c: DTMF end passthrough '2' on SIP/822-00000000


In ASTERISK-20218 the attached file it can be seen that both PA2P.rtf has both 'inband' and 'SIP INFO' set. 


This addresses bug ASTERISK-20218.
    https://issues.asterisk.org/jira/browse/ASTERISK-20218


Diffs
-----

  branches/1.8/channels/chan_sip.c 375136 

Diff: https://reviewboard.asterisk.org/r/2165/diff


Testing
-------

Asterisk SVN-branch-1.8-r375111M

I was able to verify the same conditions on a Grandstream GXP2000.

Below is after proposed patch:

file:/var/log/asterisk/dtmf when only '8' was hit once
[2012-10-17 20:04:31.305694] DTMF[23415] channel.c: DTMF begin '8' received on SIP/gxp-822-00000000
[2012-10-17 20:04:31.305738] DTMF[23415] channel.c: DTMF begin ignored '8' on SIP/gxp-822-00000000
[2012-10-17 20:04:31.445238] DTMF[23415] channel.c: DTMF end '8' received on SIP/gxp-822-00000000, duration 127 ms
[2012-10-17 20:04:31.445259] DTMF[23415] channel.c: DTMF end passthrough '8' on SIP/gxp-822-00000000

Console:
    -- Executing [s at voicemail-main:2] VoiceMailMain("SIP/822-00000000", "") in new stack
    -- <SIP/822-00000000> Playing 'vm-login.gsm' (language 'en')
[2012-10-17 20:04:31.407307] WARNING[23399]: chan_sip.c:19239 handle_request_info: Ignoring DTMF_INFO message as DTMF_INBAND is set on channel SIP/822-000000                                              00
    -- <SIP/822-00000000> Playing 'vm-password.gsm' (language 'en')


Thanks,

Alec

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121017/1ecf9fc1/attachment.htm>